Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two Small Changes Related to ZDC LUTs #46345

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Two Small Changes Related to ZDC LUTs #46345

merged 1 commit into from
Oct 11, 2024

Conversation

JHiltbrand
Copy link
Contributor

@JHiltbrand JHiltbrand commented Oct 10, 2024 •
edited
Loading

PR description:

In consultation with ZDC software expert @hjbossi and fellow HCAL trigger expert @Michael-Krohn.

First change in HcaluLUTTPGCoder

  • When determining zeroing for the ZDC LUT, 1 pedestal width shall be used in the calculation on L655, rather than 5 pedestal widths.

Second change in HcalLutManager

  • When generating the ZDC LUT XML, an additional else if case is added for topbottom FPGA label corresponding to u.

PR validation:

Only the first change to the HcaluLUTTPGCoder will result in some small changes to emulated ZDC trigger primitives. The second change to HcalLutManager only affects the generation of ZDC LUT XML files.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR will be backported to 14_1_X (#46346).

@cmsbuild cmsbuild added this to the CMSSW_14_2_X milestone Oct 10, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 10, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46345/42175

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @JHiltbrand for master.

It involves the following packages:

  • CalibCalorimetry/HcalTPGAlgos (alca, l1)
  • CaloOnlineTools/HcalOnlineDb (db)

@aloeliger, @atpathak, @cmsbuild, @consuegs, @epalencia, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @abdoulline, @bsunanda, @mmusich, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@hjbossi hjbossi mentioned this pull request Oct 10, 2024
Merged
@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38fae7/42118/summary.html
COMMIT: aaeefc4
CMSSW: CMSSW_14_2_X_2024-10-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46345/42118/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+1

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6d1fe16 into cms-sw:master Oct 11, 2024
11 checks passed
cmsbuild added a commit that referenced this pull request Oct 15, 2024
@cmsbuild
Merge pull request #46346 from JHiltbrand/twoMinorZDCthings141X
d349d48 
[Backport to 14_1_X (#46345)]: Two Small Changes Related to ZDC LUTs
@cmsbuild cmsbuild mentioned this pull request Oct 16, 2024
Merged
@JHiltbrand JHiltbrand deleted the twoMinorZDCthings142X branch October 29, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved code-checks-approved db-approved fully-signed l1-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_14_2_X
Development

Successfully merging this pull request may close these issues.
5 participants
@JHiltbrand @cmsbuild @perrotta @aloeliger @mandrenguyen